[SPARK-52142][SQL] Display table constraints in SHOW CREATE TABLE COMMAND #51541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gengliangwang
commented
Jul 17, 2025
| name, | ||
| definition(), | ||
| enforced ? "ENFORCED" : "NOT ENFORCED", | ||
| validationStatus, |
Member
There was a problem hiding this comment.
For my understanding, where can we see the status after this, @gengliangwang ?
Member
Author
There was a problem hiding this comment.
No. We have to remove it since the validation status is not supported in the parser.
We can still display it in the "DESC TABLE" command
dongjoon-hyun
approved these changes
Jul 17, 2025
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM if DESC TABLE serves the purpose. Thank you, @gengliangwang .
cc @peter-toth
peter-toth
approved these changes
Jul 18, 2025
Contributor
|
There seem to be some relevant test failures in the logs. @gengliangwang , can you please take a look those? |
Member
Author
|
@dongjoon-hyun @peter-toth Thanks for the review, merging to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Display table constraints in the SHOW CREATE TABLE COMMAND
Why are the changes needed?
Displaying table constraints is expected for the SHOW CREATE TABLE COMMAND
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit test
Was this patch authored or co-authored using generative AI tooling?
No